Fix python warnings about filehandles left open#297
Open
maartenboersma wants to merge 2 commits into
Open
Conversation
…ge, we should also close it after writing a line
Collaborator
|
OpenRAM was originally written in Python 2.x before there even was a decent logger. Thanks for your issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't like python warnings, so we run with
export PYTHONWARNINGS=error.This floods the console with warnings like this.
I found the problem (re-opening a file over and over again, never closing it) and fixed them by closing the filehandle after use.
Side recommendation: don't write your own logger infrastructure ever again. Others did it for you