Repository navigation
ci: build firmware on Python 3.13 so releases use current ESPHome - #53
Merged
Merged
Conversation
ESPHome 2026.10 needs Python 3.12+. With the workflow on 3.11, `pip install esphome` silently installed 2026.6.5, the last release that still supported 3.11, so every release through v2.12.2 was built on it. Regression gate (ESPHome 2026.6.5 vs 2026.10.2, both boards): entity and behaviour gates clean. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
valar-motion v0.3.2 parses the Timezone string on the device; ESPHome 2026.10 removed the parser behind set_timezone(), so v0.3.1 no longer compiled. Behaviour unchanged for every valid POSIX TZ string. ESPHome 2026.10 builds with ESP-IDF directly and writes the images to .esphome/build/<name>/build/ instead of .pioenvs/<name>/; the release step now finds them in either place and fails loudly if it can't. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Core, product and scheduling all register on_boot at priority -100, and several intervals share a period. The gate keyed bodies by priority or period alone, so the last one overwrote the others and a change in a hidden block (e.g. scheduling's on_boot) was never compared. Group them under the anchor in merge order instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ESPHome 2026.10 needs Python 3.12+. The workflow ran Python 3.11, so
pip install esphomesilently installed 2026.6.5, the last release that still supported 3.11. Every release through v2.12.2 was built on it. This moves CI to Python 3.13, so releases build on current ESPHome (2026.10.2 today).Changes
set_timezone(), whichscheduling.yamlused for the web page's Timezone box, so v0.3.1 no longer compiles. v0.3.2 parses the string itself./) are now rejected with a warning instead of being read as 0..esphome/build/<name>/build/instead of.pioenvs/<name>/. The release step now finds them in either place and fails loudly if it can't.Regression gate (fixed gate)
v2.12.2 as released (ESPHome 2026.6.5 + valar-motion v0.3.1) vs this PR (ESPHome 2026.10.2 + v0.3.2):
esphome:on_boot -100:id(sntp_time)->set_timezone(...)→id(apply_timezone)->execute(...). That's the only line that changed.text:Timezone set_action: now runs theapply_timezonescript.script:apply_timezone: new (the parser).Same commit with only the ESPHome version changed (2026.6.5 vs 2026.10.2): both gates clean on both boards.
Verification
http_requestwithverify_sslkeeps it.Flash
The timezone parser itself costs about +2.0 KB on VAL3000 and +1.9 KB on VAL3100.
Other differences in the resolved config (not entities or automations)
http_request).web_server: enable_private_network_accesstrue → false (the device page is same-origin).safe_mode: boot_is_good_on_shutdown.http_request: watchdog_timeout.storageoptions.register_action(... synchronous=)notices from the stepper and tmc2209 components (informational).Not in this PR
No release. The next tag builds on this.
🤖 Generated with Claude Code