Skip to content

.github: add explicit persist-credentials for checkout action#100

Merged
makasim merged 2 commits into
VictoriaMetrics:masterfrom
rudransh-shrivastava:rudransh/explicit-persist-credentials
Jun 15, 2026
Merged

.github: add explicit persist-credentials for checkout action#100
makasim merged 2 commits into
VictoriaMetrics:masterfrom
rudransh-shrivastava:rudransh/explicit-persist-credentials

Conversation

@rudransh-shrivastava

@rudransh-shrivastava rudransh-shrivastava commented Jun 12, 2026

Copy link
Copy Markdown
Member

Add explicit persist-credentials as it's true by default.
Note: Bumped action/checkout to v2 as persist-credentials does not exist for v1.
More Info: actions/checkout#485

cc: @arkid15r

Signed-off-by: Rudransh Shrivastava <rudransh@victoriametrics.com>
@rudransh-shrivastava rudransh-shrivastava marked this pull request as ready for review June 12, 2026 09:08

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread .github/workflows/main.yml
@rudransh-shrivastava rudransh-shrivastava marked this pull request as draft June 12, 2026 09:19
Signed-off-by: Rudransh Shrivastava <rudransh@victoriametrics.com>
@rudransh-shrivastava rudransh-shrivastava marked this pull request as ready for review June 12, 2026 09:26

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@makasim makasim merged commit 091c9d5 into VictoriaMetrics:master Jun 15, 2026
2 checks passed
@rudransh-shrivastava rudransh-shrivastava deleted the rudransh/explicit-persist-credentials branch June 15, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants