Skip to content

fix(security): require authentication for the credential check endpoint #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Isaries wants to merge 1 commit into
base: develop
Choose a base branch
from
+12 −5
Open

fix(security): require authentication for the credential check endpoint #323

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions src/main/java/org/wise/portal/presentation/web/controllers/user/UserAPIController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@ private boolean isGoogleClassroomEnabled() {
return !googleClientId.isEmpty() && !googleClientSecret.isEmpty();
}

@Secured("ROLE_USER")
@PostMapping("/check-authentication")
HashMap<String, Object> checkAuthentication(@RequestParam("username") String username,
@RequestParam("password") String password) {
Expand All @@ -188,12 +189,18 @@ HashMap<String, Object> checkAuthentication(@RequestParam("username") String use
response.put("isUsernameValid", false);
response.put("isPasswordValid", false);
} else {
boolean isPasswordValid = userService.isPasswordCorrect(user, password);
response.put("isUsernameValid", true);
response.put("isPasswordValid", userService.isPasswordCorrect(user, password));
response.put("userId", user.getId());
response.put("username", user.getUserDetails().getUsername());
response.put("firstName", user.getUserDetails().getFirstname());
response.put("lastName", user.getUserDetails().getLastname());
response.put("isPasswordValid", isPasswordValid);
// Only reveal the account id and real name once the correct password has been
// provided, so this endpoint cannot be used to harvest user ids and real names
// by probing usernames.
if (isPasswordValid) {
response.put("userId", user.getId());
response.put("username", user.getUserDetails().getUsername());
response.put("firstName", user.getUserDetails().getFirstname());
response.put("lastName", user.getUserDetails().getLastname());
}
}
return response;
}
Expand Down