fix(security): re-check run ownership when batch resetting group passwords#325
Open
Isaries wants to merge 1 commit into
Open
fix(security): re-check run ownership when batch resetting group passwords#325Isaries wants to merge 1 commit into
Isaries wants to merge 1 commit into
Conversation
…words The batch student password reset only verified that the teacher owned the run when loading the form. The submit handler read the group id from the session-bound form object, which request parameters can override, and reset every member's password without re-checking ownership, letting a teacher reset another teacher's students' passwords via a different group id. Carry the run id through the form and, before resetting any passwords, verify the teacher owns the run and that the group is one of that run's periods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a teacher batch reset the passwords of a group of students, the submitted group id was not checked against a run the teacher owns. A teacher could therefore reset the passwords of another teacher's students by submitting a group id that belongs to a run they do not own. This re-checks ownership before changing any passwords.
Changes
Testing
mvnw package).