Skip to content

[RemoveNonJSOps] Stub out trunc_sat and convert ops #9313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlively merged 3 commits into from
Oct 28, 2026
+152 −2
Merged

[RemoveNonJSOps] Stub out trunc_sat and convert ops #9313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
91ab9f9
[StubUnsupportedJSOps] Stub out trunc_sat ops
tlively Oct 27, 2026
370ebd1
Merge remote-tracking branch 'origin/main' into sub-unsupported-js-tr…
tlively Oct 27, 2026
efdad5c
[StubUnsupportedJSOps] Also stub out f32.convert_i64_s
tlively Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/passes/RemoveNonJSOps.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,9 +356,20 @@ struct StubUnsupportedJSOpsPass

void visitUnary(Unary* curr) {
switch (curr->op) {
case ConvertSInt64ToFloat32:
case ConvertUInt64ToFloat32:
// See detailed comment in lowerConvertIntToFloat in
// I64ToI32Lowering.cpp.
case TruncSatSFloat32ToInt32:
case TruncSatUFloat32ToInt32:
case TruncSatSFloat64ToInt32:
case TruncSatUFloat64ToInt32:
case TruncSatSFloat32ToInt64:
case TruncSatUFloat32ToInt64:
case TruncSatSFloat64ToInt64:
case TruncSatUFloat64ToInt64:
// f32.convert_i64_s and f32.convert_i64_u do not have perfect rounding
// in all cases (see lowerConvertIntToFloat in I64ToI32Lowering.cpp),
// and trunc_sat operations are lowered using non-saturating conversions
// in wasm2js and I64ToI32Lowering.
stubOut(curr->value, curr->type);
break;
default: {
Expand Down
139 changes: 139 additions & 0 deletions test/lit/passes/stub-unsupported-js.wast
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,139 @@
;; NOTE: Assertions have been generated by update_lit_checks.py and should not be edited.

;; RUN: wasm-opt %s -all --stub-unsupported-js -S -o - | filecheck %s

(module
;; CHECK: (func $convert_s_i64_f32 (type $1) (param $x i64) (result f32)
;; CHECK-NEXT: (drop
;; CHECK-NEXT: (local.get $x)
;; CHECK-NEXT: )
;; CHECK-NEXT: (f32.const 0)
;; CHECK-NEXT: )
(func $convert_s_i64_f32 (param $x i64) (result f32)
;; Signed and unsigned i64 to f32 conversions are stubbed out.
(f32.convert_i64_s
(local.get $x)
)
)

;; CHECK: (func $convert_u_i64_f32 (type $1) (param $x i64) (result f32)
;; CHECK-NEXT: (drop
;; CHECK-NEXT: (local.get $x)
;; CHECK-NEXT: )
;; CHECK-NEXT: (f32.const 0)
;; CHECK-NEXT: )
(func $convert_u_i64_f32 (param $x i64) (result f32)
(f32.convert_i64_u
(local.get $x)
)
)

;; CHECK: (func $trunc_sat_s_f32_i32 (type $0) (param $x f32) (result i32)
;; CHECK-NEXT: (drop
;; CHECK-NEXT: (local.get $x)
;; CHECK-NEXT: )
;; CHECK-NEXT: (i32.const 0)
;; CHECK-NEXT: )
(func $trunc_sat_s_f32_i32 (param $x f32) (result i32)
;; Nontrapping float-to-int conversions are stubbed out.
(i32.trunc_sat_f32_s
(local.get $x)
)
)

;; CHECK: (func $trunc_sat_u_f32_i32 (type $0) (param $x f32) (result i32)
;; CHECK-NEXT: (drop
;; CHECK-NEXT: (local.get $x)
;; CHECK-NEXT: )
;; CHECK-NEXT: (i32.const 0)
;; CHECK-NEXT: )
(func $trunc_sat_u_f32_i32 (param $x f32) (result i32)
(i32.trunc_sat_f32_u
(local.get $x)
)
)

;; CHECK: (func $trunc_sat_s_f64_i32 (type $2) (param $x f64) (result i32)
;; CHECK-NEXT: (drop
;; CHECK-NEXT: (local.get $x)
;; CHECK-NEXT: )
;; CHECK-NEXT: (i32.const 0)
;; CHECK-NEXT: )
(func $trunc_sat_s_f64_i32 (param $x f64) (result i32)
(i32.trunc_sat_f64_s
(local.get $x)
)
)

;; CHECK: (func $trunc_sat_u_f64_i32 (type $2) (param $x f64) (result i32)
;; CHECK-NEXT: (drop
;; CHECK-NEXT: (local.get $x)
;; CHECK-NEXT: )
;; CHECK-NEXT: (i32.const 0)
;; CHECK-NEXT: )
(func $trunc_sat_u_f64_i32 (param $x f64) (result i32)
(i32.trunc_sat_f64_u
(local.get $x)
)
)

;; CHECK: (func $trunc_sat_s_f32_i64 (type $3) (param $x f32) (result i64)
;; CHECK-NEXT: (drop
;; CHECK-NEXT: (local.get $x)
;; CHECK-NEXT: )
;; CHECK-NEXT: (i64.const 0)
;; CHECK-NEXT: )
(func $trunc_sat_s_f32_i64 (param $x f32) (result i64)
(i64.trunc_sat_f32_s
(local.get $x)
)
)

;; CHECK: (func $trunc_sat_u_f32_i64 (type $3) (param $x f32) (result i64)
;; CHECK-NEXT: (drop
;; CHECK-NEXT: (local.get $x)
;; CHECK-NEXT: )
;; CHECK-NEXT: (i64.const 0)
;; CHECK-NEXT: )
(func $trunc_sat_u_f32_i64 (param $x f32) (result i64)
(i64.trunc_sat_f32_u
(local.get $x)
)
)

;; CHECK: (func $trunc_sat_s_f64_i64 (type $4) (param $x f64) (result i64)
;; CHECK-NEXT: (drop
;; CHECK-NEXT: (local.get $x)
;; CHECK-NEXT: )
;; CHECK-NEXT: (i64.const 0)
;; CHECK-NEXT: )
(func $trunc_sat_s_f64_i64 (param $x f64) (result i64)
(i64.trunc_sat_f64_s
(local.get $x)
)
)

;; CHECK: (func $trunc_sat_u_f64_i64 (type $4) (param $x f64) (result i64)
;; CHECK-NEXT: (drop
;; CHECK-NEXT: (local.get $x)
;; CHECK-NEXT: )
;; CHECK-NEXT: (i64.const 0)
;; CHECK-NEXT: )
(func $trunc_sat_u_f64_i64 (param $x f64) (result i64)
(i64.trunc_sat_f64_u
(local.get $x)
)
)

;; CHECK: (func $supported_trunc (type $0) (param $x f32) (result i32)
;; CHECK-NEXT: (i32.trunc_f32_s
;; CHECK-NEXT: (local.get $x)
;; CHECK-NEXT: )
;; CHECK-NEXT: )
(func $supported_trunc (param $x f32) (result i32)
;; Trapping float-to-int conversions are not stubbed out.
(i32.trunc_f32_s
(local.get $x)
)
)
)
Loading