wasip3: Fix trapping on read/write after shutdown#790
Merged
alexcrichton merged 2 commits intoWebAssembly:mainfrom Apr 21, 2026
Merged
wasip3: Fix trapping on read/write after shutdown#790alexcrichton merged 2 commits intoWebAssembly:mainfrom
alexcrichton merged 2 commits intoWebAssembly:mainfrom
Conversation
On shutdown the streams are closed so the `__wasilibc_{read,write}`
functions would end up trapping when passing a zero handle to the
runtime. This commit fixes this by adding checks to these function and
deferring to EOF handling in such a situation.
Additionally the write EOF handler for TCP is updated to return -1 and
set errno to `EPIPE` rather than returning 0.
badeend
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On shutdown the streams are closed so the
__wasilibc_{read,write}functions would end up trapping when passing a zero handle to the runtime. This commit fixes this by adding checks to these function and deferring to EOF handling in such a situation.Additionally the write EOF handler for TCP is updated to return -1 and set errno to
EPIPErather than returning 0.