wasip3: Fix updating offset during read/write #791
Merged
alexcrichton merged 1 commit intoWebAssembly:mainfrom Apr 22, 2026
Merged
wasip3: Fix updating offset during read/write #791alexcrichton merged 1 commit intoWebAssembly:mainfrom
alexcrichton merged 1 commit intoWebAssembly:mainfrom
Conversation
dicej
approved these changes
Apr 22, 2026
This commit refactors how `offset` is updated during the internal read/write operations on streams. This isn't applicable for TCP but matters for files, for example. There's not a great way to test the paths that were previously missing the update but the code is structured differently now to make it much harder to forget to do an update. The test modified here is a light test which doesn't reproduce the original issue but at least ensures that nonblocking paths update the offset as well.
alexcrichton
force-pushed
the
update-offsets-more
branch
from
81435d9 to
2453143
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors how
offsetis updated during the internalread/write operations on streams. This isn't applicable for TCP but
matters for files, for example. There's not a great way to test the
paths that were previously missing the update but the code is structured
differently now to make it much harder to forget to do an update. The
test modified here is a light test which doesn't reproduce the original
issue but at least ensures that nonblocking paths update the offset as
well.