-
Notifications
You must be signed in to change notification settings - Fork 114
Testify/playwright #1552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Testify/playwright #1552
Changes from all commits
9e42dde
43c2d8f
444d280
e780704
a345275
c5842f5
cbf837b
2ac346d
1f0563b
4969fb6
a3b7898
8234fc3
158e195
42c8bc7
e666fb6
b8dc0a3
188b96a
cd595a8
ce12797
b8faf64
21290a0
0a9d352
baec931
4443584
65cc4b6
171981e
6ae9d66
ef30fb6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| const { defineConfig } = require('@playwright/test'); | ||
|
|
||
| module.exports = defineConfig({ | ||
| testDir: './generated', | ||
| testMatch: /.*[tT]est\.js/, | ||
| }); |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -133,6 +133,7 @@ | |
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
|
|
||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove this added empty line
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed in new commit |
||
| </plugin> | ||
| </plugins> | ||
| </build> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,6 +18,7 @@ enum class OutputFormat { | |
| KOTLIN_JUNIT_4, | ||
| KOTLIN_JUNIT_5, | ||
| JS_JEST, | ||
| JS_JEST_PLAYWRIGHT, | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if Playwright test output you are writing is not using Jest, then this variable name is misleading. should be rather called |
||
| //CSHARP_XUNIT, //no longer supported, but there is still legacy code not removed | ||
| PYTHON_UNITTEST | ||
| ; | ||
|
|
@@ -28,6 +29,8 @@ enum class OutputFormat { | |
|
|
||
| fun isJavaScript() = this.name.startsWith("js_", true) | ||
|
|
||
| fun isPlaywright() = this.name.endsWith("_playwright", true) | ||
|
|
||
| fun isJavaOrKotlin() = isJava() || isKotlin() | ||
|
|
||
| fun isJUnit5() = this.name.endsWith("junit_5", true) | ||
|
|
@@ -41,4 +44,6 @@ enum class OutputFormat { | |
|
|
||
| fun isPython() = this.name.startsWith("python_", true) | ||
|
|
||
| fun isJsBased() = isJavaScript() || isPlaywright() | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is confusing. remove this |
||
| // Helper method for JavaScript based formats. Playwright is currently only supported for JavaScript (or TypeScript) // | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code here seems duplicated from
runNpmTests(). if indeed this function is needed (see previous comment) than should refactor (eg a single function with possible more parameters) to avoid code duplicationThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous comment