Redis actions for SMEMBERS and SINTER#1584
Open
aszyrej wants to merge 9 commits into
Open
Conversation
jgaleotti
approved these changes
Jun 24, 2026
…Master into redis-set-actions
arcuri82
requested changes
Jun 29, 2026
| val success = (dtoIndex until dtoIndex + count).all { | ||
| results.executionResults[it] | ||
| } | ||
| if (!success) println("FAILED insertion $actionIndex: ${action.getName()}") |
Collaborator
There was a problem hiding this comment.
do not use println. rather use a logger. might also want to consider if should also add a assert(false) here, eg, crash in tests but not in production if it happens
| */ | ||
| open fun getTargetKey(): String? = null | ||
|
|
||
| open fun insertionsCount(): Int = 1 |
Collaborator
There was a problem hiding this comment.
add JavaDoc explaining what this method is for
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New actions for set-type commands.
New e2e tests for APIs with no endpoints for saving data.