json patch dto conversion#1603
Open
suarezrominajulieta wants to merge 9 commits into
Open
Conversation
suarezrominajulieta
changed the title
jgaleotti
requested changes
Jun 24, 2026
| } | ||
|
|
||
| // Registers the shared JsonPatchOperation DTO and collects nested DTOs for object/array values. | ||
| private fun calculateDtoFromJsonPatch(gene: JsonPatchDocumentGene) { |
Collaborator
There was a problem hiding this comment.
replace comment with Javadoc
| private fun calculateDtoFromJsonPatch(gene: JsonPatchDocumentGene) { | ||
| val dtoName = GeneToDto.JSON_PATCH_OPERATION_DTO | ||
| val dtoClass = dtoCollector.computeIfAbsent(dtoName) { DtoClass(it) } | ||
| dtoClass.addField(GeneToDto.FIELD_OP, DtoField(GeneToDto.FIELD_OP, "String")) |
Collaborator
There was a problem hiding this comment.
replace "String" with constant value
| } | ||
|
|
||
| private fun anyType(): String { | ||
| return if (outputFormat.isJava()) "Object" else "Any" |
Collaborator
There was a problem hiding this comment.
replace "Object" and "Any" with constant values
| } | ||
|
|
||
| // Renders a JSON Patch document as a List<JsonPatchOperation>, one DTO per active operation. | ||
| private fun getJsonPatchDtoCall(gene: JsonPatchDocumentGene, counters: MutableList<Int>): DtoCall { |
Collaborator
There was a problem hiding this comment.
replace comment with Javadoc
| } | ||
|
|
||
| // Renders a single RFC 6902 operation as a JsonPatchOperation DTO with only its relevant fields set. | ||
| private fun getJsonPatchOperationCall(operation: JsonPatchOperationGene, counters: MutableList<Int>): DtoCall { |
Collaborator
There was a problem hiding this comment.
replace comment with Javadoc
| } | ||
|
|
||
| // Sets the "value" field: primitives are inlined as literals, objects/arrays delegate to DTO generation. | ||
| private fun setJsonPatchValue( |
Collaborator
There was a problem hiding this comment.
replace comment with Javadoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this pr we fix the TO-DO on json patch dtoWritter.