Repository navigation
fix(frontend): keep @types/node on the Node 24 runtime major - #269
Conversation
frontend/package.json pins the Node 24.22.1 runtime but declared the @types/node 26 types, so the checker accepted Node 26 APIs the runtime lacks. The types return to the 24 line. Agent-Session: f6561fed-d6d9-4fd1-a9d3-9db9f9613f55
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Update the Node type dependency range frontend/package.json |
The @types/node development dependency range changed from ^26.6.5 to ^24.19.2. |
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Other
Merge Risk: 
Minimal · up to b9a14
-
The dependency range now matches the stated Node 24 runtime major. No merge-blocking issue was identified in this narrow change.
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A version range shifts its place
A smaller number sets the pace
The package file records the change
One line updated, neat and strange
Type declarations find a home
While builds explore a new range to roam
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the change aligning frontend Node.js types with the pinned Node 24 runtime.
No open issues 🎉
1 file not reviewed
frontend/package-lock.json: Generated file
What changed in this PR
Aligns frontend Node.js type definitions with the pinned Node 24.22.1 runtime, avoiding type-checking against Node 26 APIs.
Changes:
- Changes
@types/nodefrom^26.6.5to^24.19.2. - Updates the lockfile to resolve
@types/node24.19.2 and its compatibleundici-typesdependency.
| File | Description |
|---|---|
frontend/package.json |
Constrains Node.js types to major version 24. |
frontend/package-lock.json |
Locks the matching Node.js types and updates undici-types to 7.24.6. |
Review effort: Balanced
Moves frontend @types/node from ^26.6.5 to ^24.19.2 so type-checking matches the pinned Node 24.22.1 runtime. svelte-check: 0 errors, 0 warnings.