Skip to content

fix(frontend): keep @types/node on the Node 24 runtime major - #269

Merged
WilliamAGH merged 1 commit into
mainfrom
dev
Nov 1, 2026
Merged

WilliamAGH merged 1 commit into
mainfrom
dev

Conversation

@WilliamAGH

Copy link
Copy Markdown
Owner

Moves frontend @types/node from ^26.6.5 to ^24.19.2 so type-checking matches the pinned Node 24.22.1 runtime. svelte-check: 0 errors, 0 warnings.

frontend/package.json pins the Node 24.22.1 runtime but declared the
@types/node 26 types, so the checker accepted Node 26 APIs the runtime
lacks. The types return to the 24 line.

Agent-Session: f6561fed-d6d9-4fd1-a9d3-9db9f9613f55
Copilot AI balanced review requested due to automatic review settings November 1, 2026 11:41
@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI; Enforced overrides: Organization
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d1f89fa4-d26c-4f4f-889d-60efb2c532a9
Commits

Reviewing files that changed from the base of the PR and between 092b546 and b9a14d7.

Files ignored due to path filters: 1
  • frontend/package-lock.json is excluded by !**/package-lock.json
Files selected for processing: 1
  • frontend/package.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Summary

Summary by CodeRabbit

  • Chores
    • No user-facing changes in this release.

The frontend development dependency range for @types/node changed from ^26.6.5 to ^24.19.2.

Changes: Frontend Type Dependency

Layer / File(s) Summary
Update the Node type dependency range
frontend/package.json
The @types/node development dependency range changed from ^26.6.5 to ^24.19.2.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: Minimal · up to b9a14

The dependency range now matches the stated Node 24 runtime major. No merge-blocking issue was identified in this narrow change.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly identifies the frontend fix and the Node 24 runtime alignment. It matches the main change.
Description check Passed The description directly explains the @types/node version change, its purpose, and the reported validation result.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

A version range shifts its place
A smaller number sets the pace
The package file records the change
One line updated, neat and strange
Type declarations find a home
While builds explore a new range to roam

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the change aligning frontend Node.js types with the pinned Node 24 runtime.

No open issues 🎉

1 file not reviewed
  • frontend/package-lock.json: Generated file
What changed in this PR

Aligns frontend Node.js type definitions with the pinned Node 24.22.1 runtime, avoiding type-checking against Node 26 APIs.

Changes:

  • Changes @types/node from ^26.6.5 to ^24.19.2.
  • Updates the lockfile to resolve @types/node 24.19.2 and its compatible undici-types dependency.
File Description
frontend/​package.json Constrains Node.js types to major version 24.
frontend/​package-lock.json Locks the matching Node.js types and updates undici-types to 7.24.6.

Review effort: Balanced

@WilliamAGH
WilliamAGH merged commit c810d3e into main Nov 1, 2026
15 checks passed

This branch was previously deployed

1 inactive deployment
development — b9a14d76 Deployed Nov 1, 2026 by WilliamAGH via docker-smoke #699
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants