main: decompile a few small helper functions#28
Merged
Conversation
khasinski
force-pushed
the
main-small-helper-decomp
branch
from
b2f25e4 to
3a499fe
Compare
Xeeynamo
approved these changes
Jun 30, 2026
Xeeynamo
left a comment
Xeeynamo
left a comment
Owner
There was a problem hiding this comment.
Looks good, thanks for contributing. I left a minor nit that could be addressed in a follow-up PR
| text_offset = D_80062E20; | ||
| D_80069490[text_index] = text_offset; | ||
| D_80062E20 = text_offset + arg0; | ||
| return (s32)(D_80063690 + text_offset); |
Owner
There was a problem hiding this comment.
Did you verify if you can remove both cast and parentheses?
Contributor
Author
There was a problem hiding this comment.
Thanks for the review and merge!
I didn’t verify removing both the cast and parentheses before this PR. I’ll test that form locally and send it with the next small cleanup/decomp PR if it still matches.
Contributor
Author
|
I checked this locally. Removing the cast and parentheses still matches; changing |
Xeeynamo
pushed a commit
that referenced
this pull request
Jun 30, 2026
## Summary - Update `func_80014C80` to return `u8*`, matching the text buffer pointer it produces - Remove the now-unneeded cast and parentheses from the return expression Follow-up to the review note in #28. ## Verification - Docker `make build`: all built executables reported `OK`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This decompiles a few small helper functions in
src/main/18B8.c:func_80014B70func_80014C80func_80015B44func_80015B50func_80015B88func_800211B8This is a small first contribution as I get familiar with the project.
A few naming observations, left out of the patch to keep the change focused:
func_80014B70appears to return the next pseudo-random byte from an 8-byte state and lookup table.func_80014BA8appears to scale that byte into a range.func_80014C80appears to allocate/register text buffer offsets.func_80015B44,func_80015B50, andfunc_80015B88appear to operate on entries in the BIN-GZIP/kernel archive stream: setting the current entry pointer, reading entry type, and reading entry id.Thank you for maintaining this project.
Verification:
make buildpasses