[gzliudan]

Summary

Implements EIP-7708 system logs from Amsterdam onwards: every value move made by EVM execution emits a Transfer(address,address,uint256) log from params.SystemAddress (0xfffffffffffffffffffffffffffffffffffffffe), covering the transaction value, the value moved by CALL/CREATE, and the value moved by SELFDESTRUCT. Ported from go-ethereum ethereum#33645, including the self-transfer guard from upstream commit 012efa11ab.

eth_simulateV1 synthesizes its own transfer logs; post-Amsterdam that would report every transfer twice. The synthetic log is suppressed for Amsterdam blocks in the same PR (geth ethereum#35617).

Changes

• params: EthTransferLogEvent.
• core/types: EthTransferLog.
• core.Transfer: emits for Amsterdam when the amount is non-zero and sender != recipient. The fork rules are passed from the VM, the only caller.
• core/vm: TransferFunc carries *params.Rules; opSelfdestruct6780 emits for a distinct beneficiary.
• internal/ethapi: traceTransfers is disabled for Amsterdam blocks in processBlock.

No burn log is emitted: EIP-8246 (go-ethereum ethereum#35219) removes the SELFDESTRUCT burn entirely and is already on the base branch as #2834, so a SELFDESTRUCT that names a distinct beneficiary is the only value move the instruction makes, and a self-destruct to self logs nothing in every fork. Amsterdam is not scheduled on any network (amsterdamBlock is nil on mainnet and testnet), so the window stays dormant until it is. Value moved outside EVM execution is out of scope too: XDCx and XDCxlending order matching settles native XDC at block level (miner/worker.go) with statedb.AddBalance/SubBalance (XDCx/tradingstate/relayer_state.go), never through core.Transfer, so those moves emit no transfer log - the same treatment the specification gives withdrawals and fees.

Log ABI

• emitter: params.SystemAddress
• topics: Transfer(address,address,uint256), from, to
• data: 32-byte amount

These logs become part of Amsterdam block receipts, so indexers that consume receipts will see them next to user logs.

Verification

• make all clean.
• gofmt clean.
• golangci-lint --new-from-rev=f5492a96a7: 0 issues.
• go test ./core/... ./internal/ethapi/... ./params/... ./tests/... ./log/... passes.
• Mutation checks: removing the Amsterdam gate fails TestEIP7708PreAmsterdam and TestEIP7708TransferForkGate, removing the self-transfer guard fails TestEIP7708SelfTransfer, removing the SELFDESTRUCT beneficiary guard fails TestEIP7708SelfdestructToSelf, breaking the transfer attribution fails TestEIP7708DelegateCallAttribution, and removing the simulate suppression fails TestSimulateV1TransferLogs/post-amsterdam.
• Boundary matrix, mirroring upstream core/eip7708_test.go: DELEGATECALL and CALLCODE (no log), the delegated-call attribution (a transfer made by delegated code belongs to the executing context), a SELFDESTRUCT to self vs. a distinct beneficiary, an inner revert that keeps the caller's own log, an outer revert that discards every log, every transaction type (legacy, access list, dynamic fee, set code) plus a delegated EOA, CREATE and CREATE2 endowments (including a failed CREATE rolling its log back), precompile, system-address and coinbase recipients, the priority-fee exclusion, and a direct core.Transfer fork-gate case pinning the 32-byte amount (core/eip7708_transfer_logs_test.go).

Closes #2767

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: a960a1da-00e2-4735-95c5-5cb182afdf4f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

🔵 Needs a closer look

Consensus-visible receipt changes require protocol-maintainer validation of log ordering, fork activation, and indexer compatibility.

No open issues 🎉

What changed in this PR

Implements Amsterdam-gated EIP-7708 native-value transfer logs in EVM execution and receipts, addressing #2767. It follows the transfer-only design compatible with EIP-8246’s removal of SELFDESTRUCT burns.

Changes:

• Adds the system-log event and constructor, emitting logs for non-zero transfers between distinct addresses.
• Suppresses synthetic transfer logs in eth_simulateV1 after Amsterdam to avoid duplicates.
• Adds coverage for fork gating, transfer attribution, reverted execution, creation, SELFDESTRUCT, and simulation.

File	Description
tests/​vm_test_util.go	Updates the VM test transfer callback signature.
params/​protocol_params.go	Defines the transfer event topic.
internal/​ethapi/​simulate.go	Disables synthetic transfer logs after Amsterdam.
internal/​ethapi/​logtracer.go	Documents synthetic and protocol log emitters.
internal/​ethapi/​api_test.go	Tests simulation logs before and after Amsterdam.
core/​vm/​interpreter_test.go	Updates the interpreter test transfer callback.
core/​vm/​instructions.go	Emits Amsterdam SELFDESTRUCT transfer logs.
core/​vm/​gas_table_test.go	Updates gas-test transfer callbacks.
core/​vm/​evm.go	Passes fork rules into CALL and CREATE transfers.
core/​vm/​eip8246_test.go	Updates the SELFDESTRUCT test transfer callback.
core/​vm/​contracts_kzg_stub_test.go	Updates the precompile test transfer callback.
core/​types/​log.go	Adds the EIP-7708 log constructor.
core/​state/​statedb_log_test.go	Tests log rollback and index restoration.
core/​evm.go	Emits fork-gated logs for value transfers.
core/​eip7708_transfer_logs_test.go	Adds execution and receipt-log regression coverage.

_{Review effort: Balanced}