Repository navigation
Fix restart_timer losing timer info - #79
Merged
Merged
Conversation
restart_timer() called cancel_timer() before start_timer(), and
cancel_timer() clears timer_trigger and timer_message_verb, so the
restarted timer was started with trigger=None and message_verb=None
("Will None in 1800 seconds"), and would trigger None when it fired.
extra_text was never saved, so it was also dropped on restart.
start_timer() already cancels the matching timer, so drop the redundant
cancel and save/pass extra_text too.
jall0h
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
restart_timer() called cancel_timer() before start_timer(), and cancel_timer() clears timer_trigger and timer_message_verb, so the restarted timer was started with trigger=None and message_verb=None ("Will None in 1800 seconds"), and would trigger None when it fired. extra_text was never saved, so it was also dropped on restart.
start_timer() already cancels the matching timer, so drop the redundant cancel and save/pass extra_text too.