Repository navigation
fix: repair audited behavior and retire obsolete code - #219
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This audit found tests exercising helpers and mutation paths that production no longer calls, alongside genuine behavior bugs. Remove only paths with no production callers and a traced replacement or current domain contract. Move meaningful assertions to active components, API handlers, transactional alert admission, and real client requests.
The five commits separate SDK, web, iOS, agent, and server changes. Regression tests were observed failing before the corresponding behavior fixes; deleted legacy tests were replaced or retained on active interfaces where their assertions remain meaningful.
Validation
Passed locally:
Final JS checks used the repository-pinned Bun 1.3.4 and Node 24.13.1.
Remaining blockers and evidence limits
The complete local gates are not all green. The failing tests remain intact:
useHistoryanduseTrafficcontract defects still need a separate API and range-semantics decision; their supported exports are retained.