Skip to content

fix for platforms without bitmaptools#81

Closed
bablokb wants to merge 1 commit intoadafruit:mainfrom
bablokb:fix-bitmaptools-missing
Closed

fix for platforms without bitmaptools#81
bablokb wants to merge 1 commit intoadafruit:mainfrom
bablokb:fix-bitmaptools-missing

Conversation

@bablokb
Copy link
Copy Markdown

@bablokb bablokb commented Apr 15, 2025

This fixes #80

Tested with Blinka_Displayio_PyGameDisplay

@FoamyGuy
Copy link
Copy Markdown

I'd prefer not to add this fallback here and instead get bitmaptools implemented for Blinka_DisplayIO. I've recently begun working on just that on this branch: https://github.com/FoamyGuy/Adafruit_Blinka_Displayio/tree/bitmaptools

fill_region() and a handful of other methods are already implemented in that branch, if you're willing and interested feel free to give it a try as a way to get this library working without the need for the fallback logic that this PR adds.

I'll open a PR to Blinka_Displayio repo with it once I get a few more of the remaining functions implemented.

@bablokb
Copy link
Copy Markdown
Author

bablokb commented Apr 15, 2025

I agree that adding bitmaptools to Blinka is the correct way to go. But until this is merged, the import of Polygon already causes a program to crash with an exception. So this PR is useful as a temporary workaround. This depends on how fast your code will be merged to Blinka.

@FoamyGuy
Copy link
Copy Markdown

FoamyGuy commented May 5, 2025

bitmaptools is merged into Blinka_DisplayIO now. I think it is okay to close this and leave out compatibility for platforms missing it for now.

@FoamyGuy FoamyGuy closed this May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bitmaptools not available for non-native CircuitPython (Blinka)

2 participants