Skip to content

wip: enable keyboard scrolling in S2 Popover when content overflows #10091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
yihuiliao wants to merge 3 commits into
base: main
Choose a base branch
from
+6 −5
Draft

wip: enable keyboard scrolling in S2 Popover when content overflows #10091

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec0f952
fix: enable keyboard scrolling in S2 Popover when content overflows
yihuiliao May 20, 2026
7657f46
fix formatting
yihuiliao May 20, 2026
58b074e
cleanup
yihuiliao May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions packages/@react-spectrum/s2/src/Popover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,13 @@ let popover = style(
default: 'elevated',
isArrowShown: 'none'
},
outlineStyle: 'solid',
Copy link
Copy Markdown
Member Author

@yihuiliao yihuiliao May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

I'm not sure if there was reason we were using outline over borders. However, since overflow: auto was moved to the popover and not inner div, the outline was appearing on top of the scrollbar. Using border ensures that it appears underneath.

*ignore the squished image, i didn't want it take up too much space but you can see where the outline is

outlineWidth: 1,
outlineColor: {
borderStyle: 'solid',
borderWidth: 1,
borderColor: {
default: lightDark('transparent-white-25', 'gray-200'),
forcedColors: 'ButtonBorder'
},
outlineStyle: 'none',
width: {
size: {
// Copied from designs, not sure if correct.
Expand Down Expand Up @@ -154,7 +155,8 @@ let popover = style(
isolation: 'isolate',
pointerEvents: {
isExiting: 'none'
}
},
overflow: 'auto'
},
getAllowedOverrides()
);
Expand Down Expand Up @@ -322,7 +324,6 @@ const innerDivStyle = style(
boxSizing: 'border-box',
outlineStyle: 'none',
borderRadius: 'inherit',
overflow: 'auto',
position: 'relative',
width: 'full',
maxSize: 'inherit'
Expand Down