Repository navigation
fix(files): translate the upload counts, media load errors and loading text - #1379
Merged
Merged
Conversation
The file panel's upload result counts ("2 uploaded", "1 skipped",
"1 failed") and the image, audio and video previews' load errors were
hard-coded English, so they stayed English in the Chinese UIs. They now
go through files.* messages in en, zh-CN and zh-TW; the English text is
unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The file tree showed a hard-coded "Loading files..." although the files.loading message with that text already exists in every language. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
This was referenced Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With the UI set to 简体中文 or 繁體中文, three places in the file panel stay English:
2 uploaded,1 skipped,1 failed(components/FileExplorer.tsx).Failed to load image/audio/video(components/FileViewer.tsx).Loading files...(components/FileExplorer.tsx), although thefiles.loadingmessage with that text already exists in every language.The rest of both panels is already translated (the upload buttons, the conflict prompt,
Add all uploaded files to chat, …).Reproduce on
main2 uploaded. Upload them again and pick 跳过已有文件:2 skipped.broken.pngthat is not really a PNG:Failed to load image.Fix
files.*messages inen,zh-CNandzh-TW, with{count}as a parameter asdocs/i18n.mdasks. The English strings are exactly the old ones.files.loadingmessage.Checks
npm test(2869 passed, 0 failed),node_modules/.bin/tsc --noEmit,npm run lint.🤖 Generated with Claude Code