Skip to content

fix(server): scope auth upstream CA to HTTP provider#232

Merged
namrataghadi-galileo merged 2 commits into
mainfrom
fix/auth-upstream-ca-file
May 27, 2026
Merged

fix(server): scope auth upstream CA to HTTP provider#232
namrataghadi-galileo merged 2 commits into
mainfrom
fix/auth-upstream-ca-file

Conversation

@abhinav-galileo
Copy link
Copy Markdown
Collaborator

Summary

  • add AGENT_CONTROL_AUTH_UPSTREAM_CA_FILE for http_upstream auth
  • build an upstream-specific SSLContext instead of relying on process-wide SSL_CERT_FILE
  • cover provider and env wiring behavior in auth framework tests

Testing

  • uv run --package agent-control-server pytest server/tests/test_auth_framework.py -q
  • uv run --package agent-control-server ruff check --config pyproject.toml server/src/agent_control_server/auth_framework server/tests/test_auth_framework.py
  • uv run --package agent-control-server mypy --config-file pyproject.toml server/src/agent_control_server/auth_framework
  • pre-push hook ran make lint and make typecheck

@codecov
Copy link
Copy Markdown

codecov Bot commented May 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@abhinav-galileo abhinav-galileo changed the title Scope auth upstream CA to HTTP provider fix(server): scope auth upstream CA to HTTP provider May 25, 2026
@abhinav-galileo abhinav-galileo marked this pull request as ready for review May 25, 2026 17:41
@abhinav-galileo abhinav-galileo force-pushed the fix/auth-upstream-ca-file branch from 422d766 to 5db2357 Compare May 27, 2026 09:22
Comment thread server/src/agent_control_server/auth_framework/config.py
@abhinav-galileo abhinav-galileo force-pushed the fix/auth-upstream-ca-file branch from 5db2357 to f482f44 Compare May 27, 2026 16:04
@namrataghadi-galileo namrataghadi-galileo merged commit 7a0ce21 into main May 27, 2026
6 checks passed
@namrataghadi-galileo namrataghadi-galileo deleted the fix/auth-upstream-ca-file branch May 27, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants