Allow float thresholds in compare_batch_results#231
Merged
agentmorris merged 1 commit intoJun 25, 2026
Merged
Conversation
This change allows the direct pairwise compare_batch_results API to accept a single numeric detection threshold in addition to the existing category-to-threshold dictionary format. Numeric thresholds are normalized to a default threshold dictionary, preserving the existing per-category dictionary behavior and the current default fallback logic. Focused tests were added for float normalization, integer normalization, existing dictionary preservation, invalid input handling, and the direct pairwise path that previously failed when numeric thresholds reached the existing .values() logic.
Owner
|
Merged via PR 232, thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows the direct pairwise compare_batch_results API to accept a single numeric detection threshold in addition to the existing category-to-threshold dictionary format. Numeric thresholds are normalized to a default threshold dictionary, preserving the existing per-category dictionary behavior and the current default fallback logic.
Focused tests were added for float normalization, integer normalization, existing dictionary preservation, invalid input handling, and the direct pairwise path that previously failed when numeric thresholds reached the existing .values() logic.