Skip to content

PROD-2195 / PROD-2196: remove deprecated system args, fix --help, correct README#163

Merged
5PK merged 1 commit into
mainfrom
PROD-2195-2196-revised
Jun 16, 2026
Merged

PROD-2195 / PROD-2196: remove deprecated system args, fix --help, correct README#163
5PK merged 1 commit into
mainfrom
PROD-2195-2196-revised

Conversation

@5PK

@5PK 5PK commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Supersedes #162 (which was based on the now-outdated PROD-2195-2196 branch — it documented flags that this PR removes).

PROD-2195 — system-args cleanup

Removed the following CLI flags and collapsed their code paths:
--rootPath, --insecure, --legacyFolders, --local, --preprod, --locale (kept --locales), --preview, --baseURL, --model (kept --models), --test, --dryRun, --force, --update/--forceUpdate, --reset.

  • Pure feature-gate flags (insecure/SSL, reset, dryRun, test mode, legacy folders, local/preprod env modes) had their branches removed entirely.
  • Per decision: downloaders now always re-download (state.update removed).
  • state.rootPath / state.baseUrl / state.preview kept as fixed internal values the code still needs (the user-facing flags are gone).
  • Fixed a real --help bug: --sourceGuid, --targetGuid, --overwrite, --autoPublish were silently hidden from --help because each listed its own key name as an alias. Removed the self-referential aliases and expanded their help text.
  • Updated affected unit tests; added regression tests guarding against self-aliases and missing describe.

PROD-2196 — README accuracy (reconciled with the removals above)

  • --overwrite documented as conflict-scoped (verified against the pushers).
  • --models-with-deps documented as including pages + templates (verified against the dependency-tree builder).
  • pull --sourceGuid marked optional with AGILITY_GUID fallback.
  • Documented the surviving previously-missing flags (--channel, --token, --dev, --contentIDs, --pageIDs); did not re-add removed flags.
  • --elements default now includes Sitemaps.
  • Env-var table corrected: removed AGILITY_MODELS_WITH_DEPS (never primed by the code) and added AGILITY_DEV.

Verification

  • tsc build clean.
  • Full unit-test suite passes (run per-file): 1,659 tests green.
  • agility pull/sync --help now renders all four previously-hidden flags with accurate descriptions.

🤖 Generated with Claude Code

…rect README

PROD-2195 (system-args cleanup):
- Remove CLI flags: --rootPath, --insecure, --legacyFolders, --local, --preprod,
  --locale (keep --locales), --preview, --baseURL, --model (keep --models),
  --test, --dryRun, --force, --update/--forceUpdate, --reset
- Collapse the now-dead code paths (insecure/SSL, reset, dryRun, test mode,
  legacy folders, local/preprod env modes); downloaders always re-download
- Fix self-referential aliases that hid --sourceGuid/--targetGuid/--overwrite/
  --autoPublish from --help; expand their help text
- Keep state.rootPath/baseUrl/preview as fixed internals the code still needs
- Update affected unit tests; add --help regression tests

PROD-2196 (README accuracy, reconciled with the flag removals above):
- --overwrite documented as conflict-scoped (matches the pushers)
- --models-with-deps documented as including pages + templates
- pull --sourceGuid marked optional with AGILITY_GUID fallback
- Document surviving flags (--channel/--token/--dev/--contentIDs/--pageIDs);
  do not re-add removed flags
- --elements default now includes Sitemaps; env-var table corrected

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@5PK 5PK merged commit d3b177c into main Jun 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants