fix(PROD-2211): robust handling of model "Unable to save the model" failures

[jules-exel]

PROD-2211

The model pusher (src/lib/pushers/model-pusher.ts) mishandled saveModel failures: it left incomplete mappings, silently dropped models, and reported success when models actually failed. The Unable to save the model. string comes from @agility/management-sdk (which just rethrows any failure generically) — the disambiguation has to happen in the CLI, which is where all of this lands. Neither SDK needed changes.

Fixes

1. Verify-then-recover on a failed save (creates and updates).
saveModel can reject even though the API persisted the model (timeout-with-server-completion, response-parse race). The catch now re-queries the target by (referenceName, contentDefinitionTypeID):

• Create → recovered if a matching model now exists.
• Update → recovered only if the saved field count matches the source, so a genuine reject (e.g. a 404 Definition for setting X not found, which leaves fields unapplied) correctly stays failed.

Recovered saves write the mapping and report success (silently).

2. Report failures honestly.
The update loop used if (result) where result is the string "updated" | "failed" — "failed" is truthy, so failed field-updates were counted as successes and the banner went green. Now compares === "updated", so failures increment failed, surface in the ERROR SUMMARY, and flip the banner.

3. Map-on-adopt.
When a model exists on the target by reference but has no mapping row, the non-default branch previously set targetModel and fell through every condition (all gated on sourceMapping), silently dropping the model. It now writes the mapping and skips, so re-syncs self-heal instead of wedging.

4. Type-aware lookups.
Model lookups are keyed by (referenceName, contentDefinitionTypeID) with a name-only fallback (older pulls/fixtures), closing the same-name different-type collision (e.g. a Content List vs a Module both named PromoBanner) — the PROD-1505 family.

Bonus: logger.model.error now unwraps the SDK's innerError, so the real API status + response body land in the log file instead of the generic Unable to save the model. (replaces a raw console.error debug block).

Tests

6 new cases in model-pusher.test.ts: failed-update-stays-failed, false-negative create recovery, different-type-same-name stays failed, failed-update recovery on field-count match, map-on-adopt writes the mapping + skips, and type-blind non-adoption. Full suite 1711 passing, typecheck clean.

Related

• PROD-2187 / PR fix(PROD-2187): pull linked-content model references for --models and --models-with-deps #164 — fixed the dependency-resolution 404 (referenced models not pulled); merged separately.
• PROD-1505 — type-blind referenceName-only lookup.
• PROD-1504 — ERROR SUMMARY under-reporting (same false-success family as fix Package changes #2).

🤖 Generated with Claude Code