Skip to content

Implmemnted Feature Windows Gameserver Move Alpha to beta#4560

Open
Sivasankaran25 wants to merge 12 commits into
agones-dev:mainfrom
Sivasankaran25:feature/widowsgameserver
Open

Implmemnted Feature Windows Gameserver Move Alpha to beta#4560
Sivasankaran25 wants to merge 12 commits into
agones-dev:mainfrom
Sivasankaran25:feature/widowsgameserver

Conversation

@Sivasankaran25

Copy link
Copy Markdown
Collaborator

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #4523

Special notes for your reviewer:

@Sivasankaran25 Sivasankaran25 requested a review from a team May 11, 2026 09:01
@Sivasankaran25 Sivasankaran25 self-assigned this May 11, 2026
@github-actions github-actions Bot added kind/feature New features for Agones size/M labels May 11, 2026
@agones-bot

Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: 1d89798a-9fcf-422e-a2a2-c65b60892f56

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot

Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: e35ec88a-3848-4a70-8f87-3fe1b11a06e5

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@Sivasankaran25

Copy link
Copy Markdown
Collaborator Author

/gcbrun

@agones-bot

Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: 0894d8f3-6aa3-484e-8c51-b7d089f35370

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot

Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: f680848d-d334-4731-a973-ddd02c1184e4

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot

Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: 441eecfa-987c-407a-9c93-4dfaa26a41b6

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot

Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: c486f2ce-f194-47ec-a6cf-7a9112176a76

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@Sivasankaran25

Copy link
Copy Markdown
Collaborator Author

/gcbrun

@agones-bot

Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: 03abe090-4b08-4114-85dc-109f562c5d16

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GKE Autopilot does not support Windows Nodes https://docs.cloud.google.com/kubernetes-engine/docs/concepts/windows-server-gke#limitations. Try running tests on Standard only.

@agones-bot

Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: d9561616-5ef7-4585-9398-81a4d7bce436

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot

Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: d899272a-a35a-4aed-86fa-6eb15696a675

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot

Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: c4b35f9c-0c5d-421a-a377-e514d5730e33

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel

Copy link
Copy Markdown
Member

Curious to hear how the work here is going? I can't see the clusters, but what is failing here?

@Sivasankaran25

Copy link
Copy Markdown
Collaborator Author

Curious to hear how the work here is going? I can't see the clusters, but what is failing here?

The e2e-windows-smoke test step failed because GKE Autopilot does not support Windows nodes. The test must be configured to run only on GKE Standard clusters. Please suggest possible approaches to fix this build error.

@markmandel

Copy link
Copy Markdown
Member

Could we use something like what we did here to skip autopilot?

framework.SkipOnCloudProduct(t, "gke-autopilot", "does not support Static PortPolicy")

@Sivasankaran25

Copy link
Copy Markdown
Collaborator Author

Could we use something like what we did here to skip autopilot?

framework.SkipOnCloudProduct(t, "gke-autopilot", "does not support Static PortPolicy")

Yes Sure I will try

@agones-bot

Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: 3ab22cd7-7fe0-41b2-b442-25b7e0366410

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot

Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: d9c984fe-6414-419b-97de-45d737e5cc2c

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

containers:
- name: simple-game-server
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.43
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.42-windows_amd64-ltsc2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be necessary -- the manifest should load the windows image.

{{% alert title="Warning" color="warning" %}}
Running `GameServers` on Windows nodes is currently Alpha, and any feedback
would be appreciated.
{{% alert title="Note" color="info" %}}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All doc changes need to be feature shortcoded - https://agones.dev/site/docs/contribute/documentation-editing-contribution/

| linux | `amd64` | **Stable** |
| linux | `arm64` | Alpha |
| [windows] | `amd64` | Alpha |
| [windows] | `amd64` | Beta |

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here - feature shortcoded.

Comment thread test/e2e/windows_test.go

// windowsGameServerImage is the published windows/amd64 simple-game-server.
// Uses ltsc2019 — the currently available tag in agones-images registry.
const windowsGameServerImage = "us-docker.pkg.dev/agones-images/examples/simple-game-server:0.42-windows_amd64-ltsc2019"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd double check the manifest for this image - but pretty sure it's a multi-arch and should select the correct image by detecting the host arch

# The test itself calls t.Skip() when CloudProduct == "gke-autopilot".
# Runs parallel with e2e-feature-gates to avoid adding wall-clock time.
#
- name: e2e-runner

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 if the test windows_test.go is in the e2e folder - why do we need this extra entry in this config? Shouldn't it just run in the standard e2e test suite?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature New features for Agones size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move Windows (windows/amd64) GameServer support from Alpha to Beta

5 participants