Fix/test infra gameserver#26
Draft
NAME-ASHWANIYADAV wants to merge 2 commits into
Draft
Conversation
Signed-off-by: ashwani yadav <22ashwaniyadav@gmail.com>
Signed-off-by: ashwani yadav <22ashwaniyadav@gmail.com>
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
What this PR does
Introduces Vitest testing infrastructure and adds 29 unit tests for the
GameServerresource model.Testing infra:
vitest.config.ts- Configures Vitest withjsdomenvironment and aliases@kinvolk/headlamp-plugin/lib/k8s/clusterto a lightweight mock (the real path is externalized at build time and cannot be resolved in tests).src/__testutils__/kubeObjectMock.ts- MinimalKubeObjectstand-in verified against the real Headlamp source.package.json- Updates thetestscript fromheadlamp-plugin testtovitest run.GameServer tests (29 tests):
state,address,nodeName,fleet,ports,counters,lists,eviction,addresses,reservedUntil,mergedPorts.Did you use AI tools in preparing this PR?:
Y
Test plan
Automated checks
npm cinpm run buildnpm run tscnpm run lintnpm run format -- --checknpm run testManual verification
N/A - test infrastructure and unit tests only.
Notes for reviewers
The
KubeObjectmock was verified against the real Headlamp source (this.jsonData = json,get metadata() { return this.jsonData.metadata }). Theevictiongetter defaults to'Never', matching the upstream Agones Go code (EvictionSafeNeveringameserver.go:486).