Repository navigation
A registry credential is a Secret an image names - #183
Merged
Merged
Conversation
providers.md already described the reference model -- create a Secret, reference it from an Image -- and resource-definitions.md already listed secret_id as the Image field. The implementation never got there, and images-service.md plus the product docs were written to match the code instead. Reconciles them to the reference model, adds the organization constraint on secret_id, and adds Image to the secrets.md referential-integrity table, which omitted it entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describes the change implemented in agynio/images#3, agynio/secrets#26, agynio/console-app#146, agynio/terraform-provider-agyn#90 and agynio/api#190.
The docs described two different models
providers.md already said a registry password is "an ordinary Secret referenced by an Image", with a Registry Credential Setup flow to match, and resource-definitions.md already listed
secret_idas the Image field. The implementation never got there — it took a plaintextpasswordand created the Secret behind the caller's back — andimages-service.mdplus the product docs were later written to match the code instead. Neither side flagged the other.What this reconciles
images-service.md— the credential is held by reference; the organization constraint onsecret_idand why it exists;CountImagesReferencingSecret; a changed credential is read against the repository before it is stored; deleting an image leaves its Secret alone.secrets.md—Image.secret_idadded to the referential-integrity table, which listed only egress rules and subscriptions.authz.md,resource-definitions.md,product/images/images.md,product/console/console.md— brought in line.The change doc also records two things found on the way and deliberately left out of scope: the LLM service's
ResolveSecretExistscheck does not compare organizations, and the Secrets service performs no authorization checks in its handlers at all despitesecrets.mdspecifying one per operation.