Repository navigation
Conversation
Renaming an organization, changing its slug, editing its sandbox defaults, and deleting it are one permission, held by owners and by cluster admins. Cluster admins hold no tuple on any organization, so the relation includes admin from cluster rather than requiring owner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UpdateOrganizationandDeleteOrganizationare spec'd to checkcan_manage_organization(authz — Organization Permissions). The relation did not exist, so the service checkedownerinstead — which no cluster admin holds on any organization, on top ofDeleteOrganizationchecking nothing at all.Defined the same way as
can_manage_members:owner or admin from cluster.Model tests cover owner (true), member (false), and cluster admin (true). 31/31 tests, 236/236 checks passing.
Part of organization settings and deletion. The Organizations service change that consumes this follows separately.