Repository navigation
Sync test fakes with the api module - #211
Merged
Merged
Conversation
CI has been red on main: the test fakes stand in for generated gRPC clients, so every method added to a service proto breaks them until the fake catches up, and three had accumulated — DeleteOrganizationResources on the groups and networks clients, ListPrivateResourcesReachableBy and SetPrivateResourceMediation on networks. The failure is a compile error in the test build, which reads as though the package under test is broken rather than the stand-in for something it does not own.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI is red on
main. The cause is not the gateway's own code: its test fakes stand in for generated gRPC clients, so every method added to a service proto breaks them until the fake catches up. Three had accumulated:DeleteOrganizationResourceson the groups and networks clientsListPrivateResourcesReachableByandSetPrivateResourceMediationon networksEach shows up as a compile error in the test build, which reads as though the package under test is broken rather than a stand-in for something it does not own.
go build,go vetandgo test ./...all pass with these in place.Worth noting for later: this will recur on every api change that adds a method, and the breakage lands on whoever opens the next unrelated PR. A generated or embedded-interface fake would make it impossible.