Repository navigation
Own the platform identity here instead of granting it on request - #19
Merged
Merged
Conversation
Granting cluster admin inside RegisterIdentity was wrong twice over. It was reachable over the wire: every service calls RegisterIdentity, so any of them could name the platform type and hand itself admin on cluster:global. The grant now names exactly one identity, read from this service's own configuration, and nothing can ask for it. It also made the Gateway responsible for a fact it does not own. The Gateway triggered the grant by re-registering the identity at startup, which meant a retry loop in its main() -- convergence inside a single run, which is the shape this whole change set exists to remove. Both halves belong here: the record and the relation are what this service owns, so it converges them at its own startup. Retrying against the authorization service is ordinary startup behaviour rather than a provisioning step -- nothing waits on it, and every request is served meanwhile. RegisterIdentity goes back to being a registry write. Refs architecture/changes/2026-08-08-one-step-install.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #18, which got this wrong twice over.
It was reachable over the wire. Every service calls
RegisterIdentity, so any of them could nameIDENTITY_TYPE_PLATFORMand hand itselfadminoncluster:global. The grant now names exactly one identity, read from this service's ownPLATFORM_IDENTITY_ID, and nothing can ask for it.It made the Gateway responsible for a fact it does not own. The Gateway triggered the grant by re-registering the identity at startup, which meant a retry loop in its
main()— convergence inside a single run, which is the shape one-step-install exists to remove.Both halves belong here: the record and the relation are what this service owns, so it converges them at its own startup. Retrying against the authorization service is ordinary startup behaviour rather than a provisioning step — nothing waits on it and every request is served meanwhile.
RegisterIdentitygoes back to being a registry write. Pairs with the matching simplification in agynio/gateway#204.