Repository navigation
Cluster-wide rooms the platform holds - #43
Merged
Merged
Conversation
Third of the cluster-wide rooms, for the same reason as the other two: the Orchestrator reconciles every workload there is and cannot subscribe per workload without racing the creation of the next one.
DevSpace validates command and pipeline names against ^[a-z0-9][a-z0-9-]*[a-z0-9]$ and refuses the whole file when one carries a colon, so `devspace dev` failed before it did anything. The probes go too, or nothing ever starts: DevSpace waits for the pod to be ready before it syncs, the container waits for the sync before it listens, and the liveness probe kills it at 40s -- so the sync it is waiting for never arrives. The agents chart already nulls both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
agent_instances,sandboxesandworkloads— flat, platform-only rooms — plus verification of a platform caller againstadminoncluster:globalrather than trusting thex-identity-typeheader.A derived room set cannot be made correct for a cluster-wide reconciler: the event announcing a resource in an organization it has not enumerated goes to a room it does not hold, and these are Redis pub/sub with no replay.
Identity-keyed rooms stay closed to the platform —
instance_inbox:,thread_participant:,sandbox_owner:.Spec: Notifications — Cluster-wide rooms