Repository navigation
Default the reference-check targets to their peers - #27
Merged
Merged
Conversation
Every service Secrets asks about a reference is a peer in the same namespace, reachable at its own name. Requiring the umbrella to supply each one means an install wires three values it cannot get wrong in any interesting way, and an unset target fails DeleteSecret closed. They default now. An operator sets one only to point somewhere else.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DeleteSecretasks EgressRules, LLM and Images whether anything still references the secret. All three targets had to be supplied by the umbrella, and an unset one fails the delete closed — so an install had to wire three values that only ever have one sensible answer, and got a brokenDeleteSecretif it missed one.They now default to
egress:50051,llm:50051andimages:50051— each peer's name in its own namespace, which is where they are. The chart values remain as overrides for pointing somewhere else.This makes agynio/platform-charts#118 unnecessary; closing it.