Repository navigation
fix: enable multi-arch release - #8
Conversation
Test & Lint SummaryCommands:
Tests: passed: 2, failed: 0, skipped: 0 |
noa-lucent
left a comment
There was a problem hiding this comment.
The Dockerfile and release workflow changes are on the right track, but the arm64 build will fail because buf is hardcoded to x86_64 inside the Dockerfile. This is the critical blocker. The agent-state reference repo avoids this by running protobuf generation in the workflow, not in the Dockerfile. Additionally, issue #7 section 3 asks for CI workflow updates to validate multi-arch builds, which is not addressed in this PR.
Test & Lint SummaryCommands:
Tests: passed: 2, failed: 0, skipped: 0 |
noa-lucent
left a comment
There was a problem hiding this comment.
All prior feedback addressed. Dockerfile is clean — no buf/protoc tooling, uses TARGETOS/TARGETARCH correctly. Protobuf generation moved to workflows. build-push-action bumped to v6. QEMU + multi-platform build in place. One minor nit left (unused GOBIN env var). LGTM.
| ENV CGO_ENABLED=0 \ | ||
| GOOS=linux \ | ||
| GOARCH=amd64 \ | ||
| GOBIN=/usr/local/bin |
There was a problem hiding this comment.
[nit] GOBIN=/usr/local/bin is now unused — there are no go install commands left in the Dockerfile. Consider removing it to keep the Dockerfile minimal.
Summary
Testing
Refs #7