Repository navigation
feat: accept agent_instance identities - #24
Merged
Merged
Conversation
Agent workloads authenticate as their instance, so every trace export from one was rejected with "identity type is not agent" and, where the span carried a message id, verification failed before that with an unsupported-identity-type error. Both paths now accept the instance type alongside the class. The agents service already resolves either to the same agent and organization, and threads already accepts agent_instance as a participant type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent workloads authenticate as their instance (ziti-management now registers them as
IDENTITY_TYPE_AGENT_INSTANCE), so tracing rejected every trace export from one:Resolver.Resolvefailed withidentity type is not agentIdentityTypeMetadataValuefailed first withunsupported identity typeBoth paths now accept the instance type alongside the class. Nothing downstream needed changing — the agents service already resolves either an agent id or an instance id to the same agent and organization, and threads already accepts
agent_instanceas a participant type.Identities minted before instances existed still present the class type and keep working.