Skip to content

Issue 588 ✨ feature invert all prices for stablecoin pairs#597

Open
alchemist-bounty wants to merge 83 commits into
developmentfrom
issue-588-✨_Feature_Invert_all_prices_for_stablecoin_pairs

Hidden character warning

The head ref may contain hidden characters: "issue-588-\u2728_Feature_Invert_all_prices_for_stablecoin_pairs"
Open

Issue 588 ✨ feature invert all prices for stablecoin pairs#597
alchemist-bounty wants to merge 83 commits into
developmentfrom
issue-588-✨_Feature_Invert_all_prices_for_stablecoin_pairs

Conversation

@alchemist-bounty

@alchemist-bounty alchemist-bounty commented Jul 7, 2022

Copy link
Copy Markdown
Contributor

ℹ Overview

📝 Related Issues

🔐 Acceptance:

  • yarn test passes
  • Uses Unicode conventional commits gitmoji

@vercel

vercel Bot commented Jul 7, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
algodex-react-dev ❌ Failed (Inspect) Nov 24, 2022 at 1:08PM (UTC)

@alchemist-bounty alchemist-bounty changed the base branch from development to next3 August 5, 2022 17:09
@IYTEC IYTEC marked this pull request as ready for review September 5, 2022 20:13
Base automatically changed from next3 to development October 10, 2022 19:09

@atrefonas atrefonas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isStable in most places should be called isInverted

stablecoins have isInverted set to true by default, otherwise false

All coins can toggle between inverted and non-inverted mode using the button @stephclarkga designed.

// }

const handleChange = (e) => {
if (isBuyOrder && price === '0') {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have the fixes we recently put into the place order form?

Comment thread hooks/useAlgoExplorer.js
fetchCurrentAssetPrices
} from 'services/algoexplorer'

import { routeQueryError } from './useAlgodex'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not necessary to add this file since I ported all the hooks into /hooks. Check /hooks/http/useAlgoExplorer.js

Comment thread hooks/withAlgoExplorer.js
import ServiceError from '@/components/ServiceError'
import Spinner from '@/components/Spinner'
import withQuery from '@/hooks/withQuery'

@atrefonas atrefonas Nov 24, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comment. We might already have this file in our repo?

Comment thread services/algoexplorer.js
}
const {
data: { asset }
} = await axios.get(`${EXPLORER_INDEXER_API}/v2/assets/${id}?include-all=true`)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this use React query instead of axios?

@atrefonas atrefonas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants