Repository navigation
test: check error-channel receives (golangci-lint v2.15 errcheck) - #551
Open
almeidapaulopt wants to merge 1 commit into
Open
almeidapaulopt wants to merge 1 commit into
almeidapaulopt wants to merge 1 commit into
Conversation
golangci-lint v2.15.0 flags unchecked receives from chan error. Bind and handle (or explicitly discard with rationale) at all sites, unblocking the build workflow for every open PR (incl. #548).
almeidapaulopt
added a commit
that referenced
this pull request
Oct 29, 2026
…bt so CI 'build' can pass
5 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The build workflow runs golangci-lint
latest, which rolled to v2.15.0 on Oct 19. v2.15.0'serrchecknow flags unchecked receives fromchan error— and main carries 6 such sites in test files, so every fresh PR build fails at Lint (first seen on #548, which only touchesweb/package.json/bun.lock— the failure is base drift, not that bump).What
Bind and handle (or explicitly discard with a rationale comment) every
chan errorreceive:internal/proxyproviders/tailscale/service_proxy_test.go— 2×<-startDoneafter unblocking Start(): now asserts the errorinternal/targetproviders/docker/docker_test.go—case <-errChan: now includes the error in the Fatal messageinternal/proxymanager/port_test.go— 4 sites: 2×<-errChafter close (now assert), 1× cancellation-expected select (bound + discarded), 1× shutdown-error select (bound + discarded)internal/proxymanager/concurrency_test.go—case <-restartDonenow includes the error in the Fatal messageNote: golangci-lint's default
max-same-issues: 3hid the second wave; this fixes all sites, verified with a full-repo run.Verification
golangci-lint run ./...@ v2.15.0 (CI parity): 0 issuesgo test ./...: 25/25 packages okUnblocks #548 (rebase/re-run after this lands) and restores the lint gate for all open PRs.