Repository navigation
Conversation
Contributor
|
....feels like you just shouldn't use var. |
Author
|
Agreed, |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the bug reported in discussion #4741 (originally #4740). Thanks @kwilson21 for the clear reproduction.
An inline expression that starts with a
vardeclaration, like@input="var v = $event.target.value; if (v.length > 0) { result = 'PASS' }", never runs. The evaluator only wraps an expression in a function body when it starts withif,letorconst. Anything else is placed on the right-hand side of an assignment (__self.result = ...), sovarthrowsSyntaxError: Unexpected token 'var'. The error is only logged as a console warning and the handler does nothing.This adds
varto the same check that already handlesletandconst(#2224). The check appears in three places: the normal evaluator and both branches of the raw evaluator, so all three are updated.The two new tests in
tests/vitest/evaluator.spec.js(evaluateandevaluateRawwith a leadingvar) fail with the SyntaxError without the change and pass with it.npx vitest run tests/vitest/passes.