Repository navigation
Enable x-html in the CSP build - #4932
Open
m-develops wants to merge 1 commit into
Open
m-develops wants to merge 1 commit into
m-develops wants to merge 1 commit into
Conversation
3 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CSP build replaces
x-htmlwith a directive that throws, so apps that use it for trusted HTML render nothing under a CSP. Filament renders its own icon HTML and labels this way, which breaks under Livewire'scsp_safemode.CSP itself does not restrict what
x-htmldoes: the browser still blocks scripts and inline event handlers in the inserted HTML, and Alpine expressions in it go through the CSP evaluator like any other markup. So this removes the override and lets the CSP build use the core directive unchanged. Like in the core build, Alpine attributes in the inserted HTML are initialized, sox-htmlshould only receive trusted content, as its docs already warn.The test that expected an error now checks that
x-htmlrenders and initializes its content in the CSP build, like the core test of the same name.Discussed with @danharrin in filamentphp/filament#20661.