Repository navigation
Conversation
…essages Several messages printed by the CLI contained typos or ran two sentences together: - The application builder named the option `"app-shell"` in its errors about `server` and `index`, but the option is `appShell`. - The `emitDecoratorMetadata` note printed "by Angularand" and "explictly". - The unit-test Karma `--filter` warning printed "expression.Leading". - The `provideServerRendering()` configuration error printed "provideServerRendering().The". - `ng config` reported "Confguration file cannot be found.". - `ng update` reported "registry package identifer". Add the missing spaces, fix the spelling and use the actual option name.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request primarily focuses on fixing typos, correcting string spacing in error and warning messages, and standardizing option names (e.g., changing 'app-shell' to 'appShell' in error messages). Additionally, it reformats the ServerRoute type definition in route-config.ts to a single line. There are no review comments, and I have no feedback to provide.
alan-agius4
added
target: patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several messages printed by the CLI contained typos or ran two sentences together:
"app-shell"in its errors aboutserverandindex, but the option isappShell.emitDecoratorMetadatanote printed "by Angularand" and "explictly".--filterwarning printed "expression.Leading".provideServerRendering()configuration error printed "provideServerRendering().The".ng configreported "Confguration file cannot be found.".ng updatereported "registry package identifer".Add the missing spaces, fix the spelling and use the actual option name.