Repository navigation
fix(@angular/build): only copy root README asset by default - #34417
Merged
alan-agius4 merged 4 commits intoOct 20, 2026
Merged
Conversation
…secondary README assets - Prevent secondary entry-point default `README.md` assets from copying the root or primary `README.md` when sharing `projectRoot` or the primary entry-point directory. - Validate in `normalizeLibraryOptions` that `outputPath` is not equal to `workspaceRoot`, `projectRoot`, or a parent directory of `projectRoot` before `deleteOutputDir` executes. - Canonicalize `workspaceRoot` via `canonicalizePath` to ensure consistent Windows drive-letter casing across compilation and file watching.
…licate secondary README assets
alan-agius4
changed the title
…licate secondary README assets
alan-agius4
changed the title
alan-agius4
added
action: review
alan-agius4
marked this pull request as ready for review
October 20, 2026 09:23
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the library builder options to canonicalize the workspace root path and removes the automatic copying of README.md files for secondary entry points. It also adds comprehensive unit tests to verify that only the root README.md is copied by default and not the ones for secondary entry points. No review comments were provided, so there is no feedback to address.
alan-agius4
changed the title
…licate secondary README assets
clydin
approved these changes
Oct 20, 2026
alan-agius4
added
action: merge
Collaborator
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
README.md({ glob: 'README.md', input: projectRoot, output: '.' }) in default library assets and remove automatic secondary entry-pointREADME.mdasset rules.