Repository navigation
perf(@angular/build): wire module resolution and package.json caches in Angular host - #34439
Closed
alan-agius4 wants to merge 1 commit into
Closed
alan-agius4 wants to merge 1 commit into
alan-agius4 wants to merge 1 commit into
Conversation
…in Angular host - Always wire `host.resolveModuleNameLiterals` using `resolutionCache` (backed by `packageJsonCache`) so `NgCompilerHost.wrap` delegates to it rather than creating an uncached internal `ModuleResolutionCache` without `packageJsonCache`. - Compute missing `ts.SourceFile` versions upfront in `ensureSourceFileVersions` instead of wrapping `program.getSourceFiles` in a closure that retains `previousProgram` across watch rebuilds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
host.resolveModuleNameLiteralswithresolutionCacheandpackageJsonCache: Previously, module resolution was only wired onhostinsideif (hostOptions.fileReplacements). WhenfileReplacementswasundefined(as in@angular/build:libraryand most application builds),NgCompilerHost.wrapfell back to its own internalts.createModuleResolutionCachewithoutpackageJsonCache, leavinghost.getModuleResolutionCache()empty andpackageJsonCacheunused across watch rebuilds and.d.tsmodule specifier generation. UsingresolveModuleNameLiteralsalso replaces the deprecatedresolveModuleNameshook and passescontainingSourceFile.impliedNodeFormat.previousProgramretention chain inensureSourceFileVersions: Compute any missingts.SourceFile.versionfields upfront duringensureSourceFileVersionsinstead of wrappingprogram.getSourceFilesin a closure that retainspreviousProgramacross watch rebuilds.Benchmark
main