Repository navigation
fix(@angular/build): name the provider packages in the unit-test browsers error - #34442
Conversation
…wsers` error When `runnerConfig` is set, the up-front package check is skipped, so a missing browser provider was reported by a later check that asked users to install "playwright" or "webdriverio". The builder actually requires `@vitest/browser-playwright`, `@vitest/browser-webdriverio` or `@vitest/browser-preview`. Use the same wording as the regular check.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the error message displayed when no browser provider is installed for Vitest, explicitly listing the required packages: '@vitest/browser-playwright', '@vitest/browser-webdriverio', and '@vitest/browser-preview'. Additionally, a unit test has been added to verify that this updated error message is correctly triggered when a runner configuration skips the dependency check. There are no review comments, and the changes look solid, so I have no feedback to provide.
| ); | ||
| }); | ||
|
|
||
| it('should name the provider packages when a runner config skips the dependency check', async () => { |
There was a problem hiding this comment.
Isn't this a duplicate of the above test?
There was a problem hiding this comment.
It exercises a different path. With runnerConfig set, the up-front package check in index.ts is skipped, and the error comes from browser-provider.ts, which had the stale "playwright"/"webdriverio" wording. The two messages differ ("to be installed." versus "to be installed within the project."), but my assertion matched only the common prefix, so they looked the same. I've tightened the assertion to the text unique to the second path. I can also drop the test if you'd rather not cover it.
…st `browsers` error
alan-agius4
added
target: patch
When
runnerConfigis set, the up-front package check is skipped, so a missing browser provider was reported by a later check that asked users to install "playwright" or "webdriverio". The builder actually requires@vitest/browser-playwright,@vitest/browser-webdriverioor@vitest/browser-preview. Use the same wording as the regular check.