Repository navigation
fix(@angular/build): suggest the istanbul provider in the unit-test V8 browser coverage error - #34484
Merged
clydin merged 1 commit intoOct 22, 2026
Conversation
…8 browser coverage error When code coverage uses the V8 provider with a non-Chromium browser, the unit-test builder told users to disable coverage or remove the browser. The error predates Istanbul coverage support in the Vitest runner, so it never mentioned the option that keeps both. Suggest the `istanbul` provider first. The browser coverage e2e test now asserts the new hint.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the validation error message shown when code coverage is enabled but the configured browsers do not support the V8 coverage provider, suggesting the use of the 'istanbul' coverage provider instead. It also adds a corresponding end-to-end test assertion to verify this updated message. There are no review comments to address, and the changes look correct.
alan-agius4
added
the
target: patch
alan-agius4
approved these changes
Oct 22, 2026
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When code coverage uses the V8 provider with a non-Chromium browser, the unit-test builder told users to disable coverage or remove the browser. The error predates Istanbul coverage support in the Vitest runner, so it never mentioned the option that keeps both. Suggest the
istanbulprovider first. The browser coverage e2e test now asserts the new hint.