wgl: Fix TLS initialization when statically linked#304
Open
endrift wants to merge 1 commit into
Open
Conversation
dpogue
reviewed
Aug 8, 2025
| return epoxy_extension_in_string(getext(hdc), ext); | ||
| } | ||
|
|
||
| BOOL |
There was a problem hiding this comment.
I believe this needs to be BOOl WINAPI so that it gets defined with the __stdcall calling convention rather than __cdecl
Otherwise:
error C2440: 'function': cannot convert from 'BOOL (__cdecl *)(PINIT_ONCE,PVOID,PVOID *)' to 'PINIT_ONCE_FN'
warning C4024: 'InitOnceExecuteOnce': different types for formal and actual parameter 2
This was referenced Sep 6, 2025
melroy89
approved these changes
Sep 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DllMain wouldn't be called if the library is statically linked, so this instead initializes it in epoxy_handle_external_wglMakeCurrent instead of DllMain if it hasn't yet been initialized. By using INIT_ONCE, this is threadsafe.
Cf. #200