Repository navigation
Mark variable-read-write supported in the Go SDK capability manifest - #73421
Merged
henry3260 merged 1 commit intoSep 21, 2026
Merged
Conversation
The Go SDK gained SetVariable and DeleteVariable in apache#73084, which completes the capability, but that PR did not flip the manifest entry. The compatibility matrix in go-sdk/README.md is generated from the manifest, so it still tells readers the Go SDK can only read Variables and that writes are unavailable. The Java and TypeScript manifests already report the capability as supported, so the Go entry is the only one left disagreeing with its own SDK.
cool9850311
requested review from
amoghrajesh,
ashb and
jason810496
as code owners
September 21, 2026 00:07
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#73084 added
SetVariableandDeleteVariableto the Go SDK task client, which completes thevariable-read-writecapability, but it did not flip the entry ingo-sdk/capabilities.yaml. The compatibility matrix ingo-sdk/README.mdis generated from that manifest, so it still tells readers the Go SDK offersGetVariableonly and that writes are unavailable over the comm socket.The Java (#72676) and TypeScript manifests already report the capability as supported, so the Go entry is the only one left disagreeing with its own SDK.
Nothing catches this automatically:
scripts/ci/prek/lang_sdk_compat_matrix.pyvalidates the manifest's shape — key coverage, types, and that an unsupported entry carries nosince— but it cannot check a declaration against the code it describes.What
go-sdk/capabilities.yaml: markvariable-read-writesupported since 3.4 and drop the note, which no longer holds.go-sdk/README.md: regenerated by theupdate-go-sdk-readme-matrixprek hook.taskflow-bindingis deliberately left alone. It readsfalsefor the Go, Java and TypeScript manifests alike, so unlike this entry it is not a single SDK lagging behind its own code, and flipping it is a question for whoever added the dimension in #73314.Verification
prek run update-go-sdk-readme-matrix --all-files— regenerates, then passes on a second runprek run --from-ref upstream/main --stage pre-commitThe capability itself is already covered end to end by
test_go_sdk_variable_write.py, added in #73084.Was generative AI tooling used to co-author this PR?