Repository navigation
Document that Go SDK registration closes at Serve - #73614
Merged
jason810496 merged 1 commit intoSep 23, 2026
Merged
Conversation
Both rules were enforced in code without being written down anywhere a bundle author reads, so the first sign of either was a panic: one at startup, one on the task's first run under the supervisor.
henry3260
requested review from
amoghrajesh,
ashb and
jason810496
as code owners
September 23, 2026 12:28
jason810496
approved these changes
Sep 23, 2026
jason810496
left a comment
jason810496
left a comment
Member
There was a problem hiding this comment.
Thanks for the follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#73549 enforced two registration rules that the Go SDK docs never stated, so the first sign of either was a panic. This writes them down where a bundle author reads.
Servecloses registration.go.rstonly said "Becausemainregisters every handler beforeServe, a mistake stops the executable as soon as it starts" — a description of the convention, not of any enforcement. ARegisterleft belowServenow panics; the rst gains a paragraph saying so, and the README the same in one sentence.airflow.Contextand a missingerrorreturn....Tis a natural thing to reach for in the argument-binding section, and no stub argument can fill it, so it is now named alongside the other two.The doc comments on
Register/Servealready carry both (#73549); this is the user-facing half.related: #73549
Was generative AI tooling used to co-author this PR?