Repository navigation
Go SDK: follow-up fix for rejecting invalid task handler registrations - #73643
Merged
jason810496 merged 2 commits intoSep 25, 2026
Merged
jason810496 merged 2 commits into
jason810496 merged 2 commits into
Conversation
jason810496
requested review from
henry3260
and removed request for
amoghrajesh and
ashb
September 24, 2026 03:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Three findings from the review of #73549:
reflect.Value.CallNewTaskFunctionpanicked inside reflect before it could report a non-func input--helpignored the writerServeis given.What
Check
reflect.FuncinNewTaskFunctionbeforeValue.Pointer, which panics on anint, andValue.Type, which panics on an untypednil.bundle.NewTaskFunction(3)now returnsexpected a func as input but was intinstead of panicking.Correct the variadic rationale and tell the author what to write instead.
binding.Analyzeturns a...Ttail into one[]Tparameter, so supporting it would mean calling the function withCallSlice, and both spellings take a single argument, so[]Tstays the one spelling for that signature.Print
--helpusage to the writerservereceives instead of stderr. Only help moves: pflag writes a deprecation warning for a flag the bundle defines while it parses, so that stays on stderr where it cannot land in the middle of the--airflow-metadatamanifest.Was generative AI tooling used to co-author this PR?