Repository navigation
Correct the meaning of _arg_bindings in the serialization schema - #73644
Merged
jason810496 merged 3 commits intoSep 28, 2026
Merged
jason810496 merged 3 commits into
jason810496 merged 3 commits into
Conversation
jason810496
marked this pull request as ready for review
September 24, 2026 05:04
jason810496
requested review from
guan404ming,
henry3260 and
pierrejeambrun
September 24, 2026 05:04
1 task done
pierrejeambrun
approved these changes
Sep 24, 2026
Member
There was a problem hiding this comment.
LGTM thanks.
Is 'native dag' vs 'mixed dag' public naming ? I like those and it wold probably be easier for users to understand what's going on.
native dag reads better than or a task of a Dag a language SDK declared and serialized itself but I think Ash didn't like that.
jason810496
force-pushed
the
docs/lang-sdk/arg-bindings-schema-comment
branch
from
September 27, 2026 15:32
370a39e to
ecdaeee
Compare
jason810496
force-pushed
the
docs/lang-sdk/arg-bindings-schema-comment
branch
from
September 27, 2026 16:23
ecdaeee to
49f4526
Compare
jason810496
commented
Sep 28, 2026
Member
Author
There was a problem hiding this comment.
Thanks, good point.
I rephrased as "Used for mixed-language tasks (the @task.stub operator) or tasks defined in a non-Python SDK Dag". Btw, Ash don't like the term "mixed-language Dag" not "mixed-language Task".
In the case of "mixed-language Task", we define the Dag at Python. In another word, only one language defines the "Dag", so there shouldn't be "mixed-language Dag".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
_arg_bindingscomment in the serialization schema says the key is only present on@task.stubtasks. That is no longer the only producer: a Dag declared in a language SDK serializes its tasks withis_stuband writes_arg_bindingsitself, with no Python operator behind them.Noticed while reviewing #73436.
How
schema.json: the$commentnow covers both producers: mixed-language tasks (the@task.stuboperator) and tasks defined in a non-Python SDK Dag.ts-sdk/schema/dag-schema.json: re-synced fromschema.json, since the TS SDK vendors a copy.adr/lang-sdk/0007-taskflow-across-language-boundary.md: one consequence bullet records the second producer. Decision B is unchanged, since it describes core-side materialization from aDecoratedOperator, which still works exactly as written.No behaviour change: a
$commentis documentation inside the schema and nothing reads it.Was generative AI tooling used to co-author this PR?