Skip to content

Go SDK: check Go naming conventions with staticcheck - #73874

Merged
jason810496 merged 1 commit into
apache:mainfrom
FrankYang0529:airflow-go-sdk-staticcheck-naming
Sep 29, 2026
Merged

jason810496 merged 1 commit into
apache:mainfrom
FrankYang0529:airflow-go-sdk-staticcheck-naming

Conversation

@FrankYang0529

@FrankYang0529 FrankYang0529 commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

Followup for #73767 (comment). Go keeps initialisms in a consistent case (appID, not appId), as Go Code Review Comments describes. Introduce a staticcheck hook to go-sdk/.pre-commit-config.yaml that runs ST1003, the naming check. It can catch error naming like taskId and suggest to change to taskID.

prek run go-sdk:staticcheck --all-files

Was generative AI tooling used to co-author this PR?
  • Yes - Claude Code

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

Signed-off-by: PoAn Yang <payang@apache.org>

@jason810496 jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code level change LGTM, thanks.

Comment thread go-sdk/.pre-commit-config.yaml
@jason810496
jason810496 merged commit 4e23910 into apache:main Sep 29, 2026
172 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Backport failed to create: v3-3-test. View the failure log Run details

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
❌ v3-3-test Commit Link

You can attempt to backport this manually by running:

cherry_picker 4e23910 v3-3-test

This should apply the commit to the v3-3-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

@FrankYang0529
FrankYang0529 deleted the airflow-go-sdk-staticcheck-naming branch September 29, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants