Skip to content

Regenerate the stale TS SDK supervisor types - #74412

Merged
dheerajturaga merged 1 commit into
apache:mainfrom
astronomer:regenerate-supervisor-sdk-schemas
Oct 7, 2026
Merged

dheerajturaga merged 1 commit into
apache:mainfrom
astronomer:regenerate-supervisor-sdk-schemas

Conversation

@pierrejeambrun

Copy link
Copy Markdown
Member

#73806 added the SetExecutionTimeout message to the supervisor wire schema (task-sdk/.../execution_time/schema/schema.json) and regenerated the Go SDK models from it, but the TS SDK's generated src/generated/supervisor.ts was never regenerated. Its supervisor-schema static check (check_supervisor_schema.py, which runs pnpm run generate:supervisor and diffs) has failed on main ever since.

Regenerated supervisor.ts from the current schema: the new SetExecutionTimeout / TimeoutSeconds types are added and the downstream TypeNN aliases shift accordingly. Generated output only, no hand edits.

The Go SDK is not affected — its vendored supervisor-schema.json is byte-identical to the task-sdk snapshot and models.gen.go / discriminators.gen.go already carry SetExecutionTimeout, so #73806 regenerated it correctly; only the TS side was missed.


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Claude Opus 4.8)

Generated-by: Claude Code (Claude Opus 4.8) following the guidelines

apache#73806 added the SetExecutionTimeout message to the supervisor wire
schema and regenerated the Go SDK models from it, but the TS SDK's
generated `src/generated/supervisor.ts` was left behind. Its
supervisor-schema static check has failed on main ever since, because
the committed types no longer match what the schema produces.
@pierrejeambrun
pierrejeambrun marked this pull request as ready for review October 7, 2026 15:48

@aaron-y-chen aaron-y-chen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@dheerajturaga dheerajturaga left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, needed to fix CI

@dheerajturaga
dheerajturaga merged commit ccd96d2 into apache:main Oct 7, 2026
126 of 149 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants