Skip to content

Ask agents to measure performance-sensitive components - #74579

Merged
shahar1 merged 3 commits into
apache:mainfrom
dabla:feature/skill-performance-sensitive-components
Oct 18, 2026
Merged

shahar1 merged 3 commits into
apache:mainfrom
dabla:feature/skill-performance-sensitive-components

Conversation

@dabla

@dabla dabla commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

First step toward #74562: until the micro-benchmark suite proposed there lands, this asks agents to measure performance-sensitive paths themselves, so AI-assisted changes do not skip it. Suggested in the contributors Slack.

The pre-push review of the airflow-publish-changes skill gets a new step and a "Performance-sensitive components" section:

  • the components that run for every task, Task SDK call, log line, Dag parse or scheduler loop (Task SDK execution time, Execution API, logging and secret masking, serialization, scheduler and triggerer loops, Dag processing), with their paths;
  • how to measure: the same script on the base commit and on the change, alternating runs, medians, a control the change does not touch, timeit or the existing perf_kit helpers, assert_queries_count for database code;
  • a before/after table in the PR description, with the reason when the change is slower.

Only the skill changes, not AGENTS.md, so the skill-eval hash stays as it is. Once #74562 is in, the section can point at the benchmarks/ folders instead.


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Opus 5.5)

Generated-by: Claude Code (Opus 5.5) following the guidelines

The publish skill's pre-push review now lists the components that run for
every task, Task SDK call, log line or scheduler loop, and asks for a
before/after measurement against the base commit, with a control, when a
diff touches one of them.
@dabla dabla added the skip newsfragment check Skip the newsfragment PR number check label Oct 12, 2026
@dabla
dabla marked this pull request as ready for review October 12, 2026 09:12
@dabla
dabla requested review from Dev-iL, potiuk and shahar1 October 12, 2026 09:12
Comment thread .agents/skills/airflow-publish-changes/SKILL.md Outdated
Comment thread .agents/skills/airflow-publish-changes/SKILL.md Outdated
Co-authored-by: Dev-iL <6509619+Dev-iL@users.noreply.github.com>
Keep the component names in step 7 so the agent knows when to read the
reference, and load the table and measuring steps only when needed.
@dabla dabla self-assigned this Oct 15, 2026
@dabla
dabla requested a review from Dev-iL October 15, 2026 07:32

@Dev-iL Dev-iL left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, ty!

@shahar1
shahar1 merged commit e5c2ea9 into apache:main Oct 18, 2026
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip newsfragment check Skip the newsfragment PR number check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants